Re: [PATCH 5/5] minor: kunit: tool: s/get_absolute_path/test_data_path in unit test

On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov dlatypov@google.com wrote:

1. the name is a lie. It gives relative paths, e.g. if I run from the

same dir as the test file, it gives './test_data/<file>'

2. it's only used for generating paths to tools/testing/kunit/test_data/

So we can tersen things by making it less general.

Signed-off-by: Daniel Latypov dlatypov@google.com

This is an excellent and overdue rename/replacement.

My only note is re: the concerns I have in patch 2, where I think we probably ought to make this function actually return an absolute path. It seems from the code (and the function name) that that was the intent, so if we can fix it, that'd be ideal.

Personally, though, I'd still prefer the new test_data_path(), just have it be an actually absolute path.

-- David