On Tue, 31 Aug 2021 09:19:27 -0700 Richard Cochran wrote:
As you said later on in this thread, any API we merge now will have to last. That is why I'm being so picky here. We want new APIs to cover current HW _and_ be reasonable for the future.
I don't see a DPLL as either a PTP Hardware Clock or a Network Device. It is a PLL.
The kernel can and should have a way to represent the relationship between these three different kind of IP block. We already have a way to get from PHC to netdev interface.
Makes sense to me. I was wondering how to split things at high level into the areas you mentioned, but TBH the part I'm struggling with is the delineation of what falls under PTP. PLL by itself seems like an awfully small unit to create a subsystem for, and PTP already has aux stuff like PIN control. Then there's the whole bunch of stuff that Jonathan is adding via driver specific sysfs interfaces [1]. I was hoping the "new API" would cover his need but PLL would be a tiny part of it.
IOW after looking at the code I'm not so sure how to reasonably divide things.
[1] https://lore.kernel.org/netdev/20210830235236.309993-1-jonathan.lemon@gmail....