On Wed, 10 Nov 2021 at 21:11, Nick Desaulniers ndesaulniers@google.com wrote:
On Wed, Nov 10, 2021 at 12:09 PM Nick Desaulniers ndesaulniers@google.com wrote:
On Wed, Nov 10, 2021 at 10:04 AM Anders Roxell anders.roxell@linaro.org wrote:
When building selftests/timens with clang, the compiler warn about the function abs() see below:
exec.c:33:8: error: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Werror,-Wabsolute-value] if (abs(tst.tv_sec - now.tv_sec) > 5) ^ exec.c:33:8: note: use function 'labs' instead if (abs(tst.tv_sec - now.tv_sec) > 5) ^~~ labs
Rework to store the time difference in a 'long long' and pass that to llabs(), since the variable can be an 'int', 'long' or 'long long' depending on the architecture and C library.
Suggested-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Anders Roxell anders.roxell@linaro.org
Thanks for the patch! Reviewed-by: Nick Desaulniers ndesaulniers@google.com
ah, gmail doesn't do a great job at showing the subject when a v2 is sent in-reply-to.
oh right, sorry.
Should the oneline mention llabs rather than labs now?
You are correct, can this be changed when the patch gets applied or should I send a v3?
Cheers, Anders