2 Sep
2025
2 Sep
'25
9:01 a.m.
On Mon, Sep 01, 2025 at 10:26:07AM -0700, Jakub Kicinski wrote:
On Mon, 1 Sep 2025 14:50:08 +0100 Simon Horman wrote:
- key = _rss_key_rand(key_len)
- ethnl = EthtoolFamily()
- key = random.randbytes(key_len)
Is the update to the generation of key intended? It's not clear to me how it relates to the rest of the patch.
_rss_key_rand() gives us an array of integers in the range 0-255 while randomg.randbytes() gives us a bytearray. Difference in return type.
Thanks, it is clear now :)
Let me respin and add this to the commit msg. Looks like I was too aggressive with the decrease in 75msec timing, CI hit a 120msec run :(