On Wed, 10 Sep 2025 02:03:52 +0000 Hangbin Liu wrote:
On Tue, Sep 09, 2025 at 04:46:00PM -0700, Jakub Kicinski wrote:
On Mon, 8 Sep 2025 06:28:02 +0000 Hangbin Liu wrote:
Add a vlan over bond testing to make sure arp/ns target works. Also change all the configs to mudules.
Why are you switching everything to module? The series needs to go to net, we should avoid unnecessary cleanups. And I think changing the config is unrelated to the selftest so it should be a standalone patch in the first place?
On my local testing, there will be a lot default interfaces if all modules build in. This could make the test environment more clean. But it's just my preference.
No strong opinion on my side. Your point is fair. On the other hand sometimes dealing with modules is tricky (especially with vng when building kernel with O=build/). But not sure how much we should care about shortcomings of tooling which can be fixed. It's okay for our CI.
As you said, we can do it with a stand alone patch. I will re-post and drop the config update.
Yup! For net we should avoid it.