Re: [PATCH v4 01/16] selftests/resctrl: Fix closing IMC fds on error and open-code R+W instead of loops

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:

The imc perf fd close() calls are missing from all error paths. In addition, get_mem_bw_imc() handles fds in a for loop but close() is based on two fixed indexes READ and WRITE.

Open code inner for loops to READ+WRITE entries for clarity and add a function to close() IMC fds properly in all cases.

Fixes: 7f4d257e3a2a ("selftests/resctrl: Add callback to start a benchmark") Suggested-by: Reinette Chatre reinette.chatre@intel.com Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com

---

Thank you.

Reviewed-by: Reinette Chatre reinette.chatre@intel.com

Reinette