29 Dec
2021
29 Dec
'21
7:37 a.m.
From: Sean Christopherson seanjc@google.com Sent: Wednesday, December 29, 2021 9:05 AM
- if (vcpu->arch.xfd_out_of_sync)
Rather than adding a flag that tracks whether or not the MSR can be written by the guest, can't this be:
if (!vmx_test_msr_bitmap_write(vcpu->loaded_vmcs->msr_bitmap)) fpu_sync_guest_vmexit_xfd_state();
and forgot to mention a change different from above. It's in x86 common exit path but above is vmx specific check. I'm not sure whether it's worthy of introducing another kvm_x86_ops callback just for this minor usage.
Introducing an extra flag (e.g. vcpu->arch.xfd_disable_interception) sounds simpler here.
Thanks Kevin