On 9/8/22 4:47 AM, Leonard Crestez wrote:
On 9/8/22 09:35, Paolo Abeni wrote:
On Mon, 2022-09-05 at 10:05 +0300, Leonard Crestez wrote: [...]
diff --git a/net/ipv4/tcp_authopt.c b/net/ipv4/tcp_authopt.c new file mode 100644 index 000000000000..d38e9c89c89d --- /dev/null +++ b/net/ipv4/tcp_authopt.c @@ -0,0 +1,317 @@ +// SPDX-License-Identifier: GPL-2.0-or-later
+#include <net/tcp_authopt.h> +#include <net/ipv6.h> +#include <net/tcp.h> +#include <linux/kref.h>
+/* This is enabled when first struct tcp_authopt_info is allocated and never released */ +DEFINE_STATIC_KEY_FALSE(tcp_authopt_needed_key); +EXPORT_SYMBOL(tcp_authopt_needed_key);
+static inline struct netns_tcp_authopt *sock_net_tcp_authopt(const struct sock *sk) +{ + return &sock_net(sk)->tcp_authopt; +}
Please have a look at PW report for this series, there are a bunch of issues to be addressed, e.g. above 'static inline' should be just 'static'
What is a "PW report"? I can't find any info about this.
patchworks: https://patchwork.kernel.org/project/netdevbpf/list/
This set: https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=1...
I'm sorry to bring the next topic this late (If already discussed, I missed that point), is possible to split this series in smaller chunks?
It's already 26 patches and 3675 added lines, less that 150 lines per patch seems reasonable?
The split is already somewhat artificial, for example there are patches that "add crypto" without actually using it because then it would be too large.
Some features could be dropped for later in order to make this smaller, for example TCP_REPAIR doesn't have many usecases. Features like prefixlen, vrf binding and ipv4-mapped-ipv6 were explicitly requested by maintainers so I included them as separate patches in the main series.
The tests could be dropped from the first set along with TCP_REPAIR and /proc/net/tcp_authopt patch. That would get it down to 21 patches. From there the refactor patches could be sent first in a separate PR that would get it down to 19. Those 19 are the core feature split into small patches; they should come in together IMHO.