On Mon, Mar 02, 2020 at 02:36:48PM -0800, Brendan Higgins wrote:
On Mon, Mar 2, 2020 at 9:52 AM Kees Cook keescook@chromium.org wrote:
I'm all for unittests (I have earlier kind-of-unit-tests in lib/test_user_copy.c lib/test_overflow.c etc), but most of LKDTM is
<Minor tangent (sorry)>
I took a brief look at lib/test_user_copy.c, it looks like it doesn't use TAP formatted output. How do you feel about someone converting them over to use KUnit? If nothing else, it would be good getting all the unit-ish tests to output in the same format.
I proposed converting over some of the runtime tests over to KUnit as a LKMP project (Linux Kernel Mentorship Program) here:
https://wiki.linuxfoundation.org/lkmp/lkmp_project_list#convert_runtime_test...
I am curious what you think about this.
</Minor tangent>
Yes please! Anything that helps these tests get more exposure/wider testing is good. (That said, I don't want to lose any of the existing diagnostic messages -- _adding_ TAP would be lovely.)