On Fri, Jul 01, 2022 at 04:51:44PM +0300, Ido Schimmel wrote:
On Fri, Jul 01, 2022 at 09:47:24AM +0200, Hans S wrote:
One question though... wouldn't it be an issue that the mentioned option setting is bridge wide, while the patch applies a per-port effect?
Why would it be an issue? To me, the bigger issue is changing the semantics of "locked" in 5.20 compared to previous kernels.
What is even the use case for enabling learning when the port is locked? In current kernels, only SAs from link local traffic will be learned, but with this patch, nothing will be learned. So why enable learning in the first place? As an administrator, I mark a port as "locked" so that only traffic with SAs that I configured will be allowed. Enabling learning when the port is locked seems to defeat the purpose?
I think if learning on a locked port doesn't make sense, the bridge should just reject that configuration.