Hi Jakub,
Thank you for your email!
10 Apr 2024 20:34:54 Jakub Kicinski kuba@kernel.org:
On Wed, 10 Apr 2024 11:48:23 +0200 Matthieu Baerts (NGI0) wrote:
These patches from Geliang add support for the "last time" field in MPTCP Info, and verify that the counters look valid.
Patch 1 adds these counters: last_data_sent, last_data_recv and last_ack_recv. They are available in the MPTCP Info, so exposed via getsockopt(MPTCP_INFO) and the Netlink Diag interface.
Patch 2 adds a test in diag.sh MPTCP selftest, to check that the counters have moved by at least 250ms, after having waited twice that time.
Hi Mat, is this causing skips in selftests by any chance?
# 07 ....chk last_data_sent [SKIP] Feature probably not supported # 08 ....chk last_data_recv [SKIP] Feature probably not supported # 09 ....chk last_ack_recv [SKIP] Feature probably not supported
Yes it does, I should have added a note about that, sorry: that's because SS needs to be patched as well to display the new counters.
https://patchwork.kernel.org/project/mptcp/patch/fd9e850f1e00691204f1dfebc63...
This patch will be sent when the kernel one will be accepted.
Is it an issue? The modification of the selftests can be applied later if you prefer.
Earlier today, I was looking at changing NIPA not to mark the whole selftest as "SKIP" but I saw it was not a bug: a check is there to mark everything as skipped if one subtest is marked as skipped from what I understood. So I guess we don't want to change that :)
I'll "hide it" from patchwork for now..
pw-bot: defer
Thank you! Do you prefer if I resend only patch 1/2 for now?
Cheers, Matt