On Sun, Aug 13, 2023 at 09:39:44PM +0800, Zhangjin Wu wrote:
Let's just roll brk(), mmap() and sbrk() to their original, working, definition:
static __attribute__((unused)) void *mmap(void *addr, size_t length, int prot, int flags, int fd, off_t offset) { void *ret = sys_mmap(addr, length, prot, flags, fd, offset); if ((unsigned long)ret >= -MAX_ERRNO) { SET_ERRNO(-(long)ret); ret = MAP_FAILED; } return ret; }
Agree, only left a suggestion here [2] about whether we can apply the 2nd patch instead of rolling them back, let's discuss it in [2] thread.
(...)
I'm sorry but I can't find this "suggestion" in this yet-another-super- long-description-of-another-idea-of-redesign. In addition it's extremely painful to constantly have to go through web links to follow a single conversation. Mail works in threads for a reason. When the same discussion is handled in many parallel threads it becomes impossible to keep it focused on a specific topic. This is also why you should stop systematically responding to a message with yet another redesign suggestion, this is super hard to follow and it literally takes me several hours a week! And at the end we've not addressed the initial problem but discussed plenty of other things.
Thanks, Willy