2 May
2025
2 May
'25
12:28 p.m.
On Fri, 2 May 2025 at 14:16, Brendan Jackman jackmanb@google.com wrote:
Little bit of indentation mess here
I don't understand this code but since I was hurt by these global variables I had a look over the diff anyway, it LGTM (aside from the formatting nits), thanks.
Reviewed-by: Brendan Jackman jackmanb@google.com
Wait sorry, actually, this deletes the global vars before it deletes the references to them. That's gonna be a real pain for bisections, please can you restructure the series to prevent intervening build failures?
(I.e. if I apply just 1/4, the selftests don't compile).