Re: [PATCH v4 04/11] iommufd/viommu: Add IOMMU_VIOMMU_ALLOC ioctl

On Fri, Oct 25, 2024 at 09:05:58AM +0000, Tian, Kevin wrote:

...

From: Nicolin Chen nicolinc@nvidia.com Sent: Tuesday, October 22, 2024 8:19 AM

• viommu->type = cmd->type;
  

• viommu->ictx = ucmd->ictx;
  

• viommu->hwpt = hwpt_paging;
  

• /* Assume physical IOMMUs are unpluggable (the most likely case)
  

*/

• viommu->iommu_dev = __iommu_get_iommu_dev(idev->dev);
  

so what would happen if this assumption breaks?

I had a very verbose comments previously that Alexey suggested to optimize away.. Perhaps I should add back the part that mentions adding a refcount for pluggable ones..

Nicolin