Re: [PATCH v5 3/3] selftests/lam: Test get_user() LAM pointer handling

On 2025-01-24 at 08:32:18 -0800, Dave Hansen wrote:

On 11/27/24 09:35, Maciej Wieczor-Retman wrote: ...

...

• switch (test->later) {
• case GET_USER_USER:

• /* Control group - properly tagger user pointer */
  

• ptr = (void *)set_metadata((uint64_t)ptr, test->lam);
  

• break;
  

s/tagger/tagged/ ?

Thanks!

...

• default:

• printf("Invalid test case value passed!\n");
  

• break;
  

• }
• if (ioctl(fd, FIOASYNC, ptr) != 0)

• ret = 1;
  

• close(fd);

+error:

• munmap(ptr, PAGE_SIZE);
• return ret;

+}

I'd really prefer that the theory of operation be in a code comment and not just in the changelog.

Sure, I'll comment the ioctl() usage so it's more clear what's happening.