On Thu, Apr 18, 2024 at 12:24 PM Markus Elfring Markus.Elfring@web.de wrote:
If the device register fails, free the allocated memory before returning.
I suggest to use the word “registration” (instead of “register”) in the commit message.
Would you like to add the tag “Fixes” accordingly?
+++ b/lib/kunit/device.c @@ -131,6 +131,7 @@ static struct kunit_device *kunit_device_register_internal(struct kunit *test, err = device_register(&kunit_dev->dev); if (err) { put_device(&kunit_dev->dev);
kfree(kunit_dev); return ERR_PTR(err); }Common error handling code can be used instead if an additional label would be applied for a corresponding jump target.
How do you think about to increase the application of scope-based resource management here?
I thought about that. But I think the code is simple enough (for now) to not require an exit label.
Regards, Markus