5 May
2025
5 May
'25
3:02 p.m.
On Mon, Apr 28, 2025 at 11:10:40AM -0700, Nicolin Chen wrote:
+struct iommufd_vcmdq {
- struct iommufd_object obj;
- struct iommufd_ctx *ictx;
- struct iommufd_viommu *viommu;
- dma_addr_t addr;
It's better to add a comment to state that @addr is a guest physical address. Or not?
Yea. Let's add one:
dma_addr_t addr; /* in guest physical address space */
If it is a guest physical in a nested page table it should technically be u64 not dma_addr_t
Jason