Re: [PATCH v4 2/7] HID: bpf: export hid_hw_output_report as a BPF kfunc

On Fri, Mar 15, 2024 at 5:06 PM Randy Dunlap rdunlap@infradead.org wrote:

On 3/15/24 07:44, Benjamin Tissoires wrote:

...

+/**

• • hid_bpf_hw_output_report - Send an output report to a HID device
• • @ctx: the HID-BPF context previously allocated in hid_bpf_allocate_context()
• • @buf: a %PTR_TO_MEM buffer
• • @buf__sz: the size of the data to transfer
• • @returns the number of bytes transferred on success, a negative error code otherwise.
• */

Minimum change:

  @returns:

Preferred change:

  Returns:

"@returns" is not documented.

Thanks for the doc review (and in 5/7).

FWIW, I'm still waiting for other reviews if any, and if there are none, I'll just amend the commit before pushing.

Cheers, Benjamin

Thanks.

#Randy