Re: [PATCH v2 3/9] selftests/resctrl: Allow ->setup() to return errors

Hi Ilpo,

On 2/15/2023 5:05 AM, Ilpo Järvinen wrote:

resctrl_val() assumes ->setup() always returns either 0 to continue tests or < 0 in case of the normal termination of tests after x runs. The latter overlaps with normal error returns.

Define END_OF_TESTS (=1) to differentiate the normal termination of tests and return errors as negative values. Alter callers of ->setup() to handle errors properly.

Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest") Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test") Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com

---

Thank you

Reviewed-by: Reinette Chatre reinette.chatre@intel.com

Reinette