RE: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

[AMD Official Use Only - General]

Hi Petkov:

-----Original Message----- From: Borislav Petkov bp@alien8.de Sent: Tuesday, January 9, 2024 6:45 PM To: Meng, Li (Jassmine) Li.Meng@amd.com Cc: Rafael J . Wysocki rafael.j.wysocki@intel.com; Huang, Ray Ray.Huang@amd.com; linux-pm@vger.kernel.org; linux- kernel@vger.kernel.org; x86@kernel.org; linux-acpi@vger.kernel.org; Shuah Khan skhan@linuxfoundation.org; linux-kselftest@vger.kernel.org; Fontenot, Nathan Nathan.Fontenot@amd.com; Sharma, Deepak Deepak.Sharma@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Limonciello, Mario Mario.Limonciello@amd.com; Huang, Shimmer Shimmer.Huang@amd.com; Yuan, Perry Perry.Yuan@amd.com; Du, Xiaojian Xiaojian.Du@amd.com; Viresh Kumar viresh.kumar@linaro.org; Oleksandr Natalenko oleksandr@natalenko.name Subject: Re: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.

On Tue, Dec 05, 2023 at 02:35:31PM +0800, Meng Li wrote:

...

amd-pstate driver also uses SCHED_MC_PRIO, so decouple the

requirement

...

of CPU_SUP_INTEL from the dependencies to allow compilation in kernels without Intel CPU support.

Tested-by: Oleksandr Natalenko oleksandr@natalenko.name Reviewed-by: Mario Limonciello mario.limonciello@amd.com Reviewed-by: Huang Rui ray.huang@amd.com Reviewed-by: Perry Yuan perry.yuan@amd.com Signed-off-by: Meng Li li.meng@amd.com

---

arch/x86/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 3762f41bb092..3e57773f946a 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1054,8 +1054,9 @@ config SCHED_MC

config SCHED_MC_PRIO bool "CPU core priorities scheduler support"

• depends on SCHED_MC && CPU_SUP_INTEL
  

• select X86_INTEL_PSTATE
  

• depends on SCHED_MC
  

• select X86_INTEL_PSTATE if CPU_SUP_INTEL
  

• select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI
  select CPU_FREQ
  default y
  help
  

--

I was gonna ask why the selects but apparently mingo wants SCHED_MC_PRIO to be selectable easier:

0a21fc1214a2 ("sched/x86: Make CONFIG_SCHED_MC_PRIO=y easier to enable")

[Meng, Li (Jassmine)] Thank you for your feedback. The reason why I added the selects is just to distinguish different pstate drivers. These two drivers cannot be supported simultaneously in the same project.

So,

Acked-by: Borislav Petkov (AMD) bp@alien8.de

Thx.

-- Regards/Gruss, Boris.

https://people.kernel.org/tglx/notes-about-netiquette