Re: [PATCH v2 12/15] iommupt: Add the x86 64 bit page table format

On Thu, Jun 05, 2025 at 02:03:58PM -0700, Jacob Pan wrote:

Hi Jason,

On Mon, 5 May 2025 11:18:42 -0300 Jason Gunthorpe jgg@nvidia.com wrote:

...

+config IOMMU_PT_X86_64

•   tristate "IOMMU page table for x86 64 bit, 4/5 levels"
  

• depends on !GENERIC_ATOMIC64 # for cmpxchg64
• default n
• help

•  iommu_domain implementation for the x86 64 bit 4/5 level
  

page table.

•  It supports 4K/2M/1G page sizes and can decode a sign
  

extended

•  portion of the 64 bit IOVA space.
  

•  Selected automatically by an IOMMU driver that uses this
  

format. + config IOMMU_PT_KUNIT_TEST tristate "IOMMU Page Table KUnit Test" if !KUNIT_ALL_TESTS depends on KUNIT depends on IOMMU_PT_AMDV1 || !IOMMU_PT_AMDV1

• depends on IOMMU_PT_X86_64 || !IOMMU_PT_X86_64

Is this intended? or you mean: depends on IOMMU_PT_X86_64 || IOMMU_PT_AMDV1

It is intended, this is the kconfig pattern that says if IOMMU_PT_X86_64 is enabled and modular then IOMMU_PT_KUNIT_TEST must also be modular.

Jason