On Mon, 29 Apr 2019 11:59:04 -0700 Linus Torvalds torvalds@linux-foundation.org wrote:
I really don't care. Just do what I suggested, and if you have numbers to show problems, then maybe I'll care.
Are you suggesting that I rewrite the code to do it one function at a time? This has always been batch mode. This is not something new. The function tracer has been around longer than the text poke code.
Right now you're just making excuses for this. I described the solution months ago, now I've written a patch, if that's not good enough then we can just skip this all entirely.
Honestly, if you need to rewrite tens of thousands of calls, maybe you're doing something wrong?
# cd /sys/kernel/debug/tracing # cat available_filter_functions | wc -l 45856 # cat enabled_functions | wc -l 0 # echo function > current_tracer # cat enabled_functions | wc -l 45856
There, I just enabled 45,856 function call sites in one shot!
How else do you want to update them? Every function in the kernel has a nop, that turns into a call to the ftrace_handler, if I add another user of that code, it will change each one as well.
-- Steve