On Thu, Jan 30, 2025 at 12:36 AM Kent Overstreet kent.overstreet@linux.dev wrote:
I've fetched it to my repo and added it to the CI:
https://evilpiepirate.org/~testdashboard/ci?user=kmo&branch=eytzinger
Ah, the following went wrong in "bcachefs: convert eytzinger0_find to be 1-based":
diff --git a/fs/bcachefs/eytzinger.h b/fs/bcachefs/eytzinger.h index d3e8b9edf335..3afb346b0738 100644 --- a/fs/bcachefs/eytzinger.h +++ b/fs/bcachefs/eytzinger.h @@ -308,7 +308,7 @@ static inline int eytzinger0_find_ge(void *base, size_t nr, size_t size, #define eytzinger0_find(base, nr, size, _cmp, search) \ ({ \ size_t _size = (size); \ - void *_base1 = (base) - _size; \ + void *_base1 = (void *)(base) - _size; \ const void *_search = (search); \ size_t _nr = (nr); \ size_t _i = 1; \
The eytzinger0_find() macro is still a bit of a mess.
I've updated https://git.kernel.org/pub/scm/linux/kernel/git/agruen/linux.git/log/?h=bcac....
Thanks, Andreas