Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests

On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote:

Set the tests to run serially to avoid conflicts with test_xdp_veth_redirect

I think this has been fixed in v3?

Others lgtm also. Thanks for working on this.

+void test_xdp_veth_broadcast_redirect(void) +{

• if (test__start_subtest("0/BROADCAST"))

• xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST);
  

• if (test__start_subtest("0/(BROADCAST | EXCLUDE_INGRESS)"))

• xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
  

• if (test__start_subtest("DRV_MODE/BROADCAST"))

• xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE, BPF_F_BROADCAST);
  

• if (test__start_subtest("DRV_MODE/(BROADCAST | EXCLUDE_INGRESS)"))

• xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE,
  

• 			    BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
  

• if (test__start_subtest("SKB_MODE/BROADCAST"))

• xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE, BPF_F_BROADCAST);
  

• if (test__start_subtest("SKB_MODE/(BROADCAST | EXCLUDE_INGRESS)"))

• xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE,
  

• 			    BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS);
  

+}