On Tue, May 10, 2022 at 6:08 AM Michal Hocko mhocko@suse.com wrote:
On Mon 09-05-22 20:00:14, Suren Baghdasaryan wrote:
With the last usage of MMF_OOM_VICTIM in exit_mmap gone, this flag is now unused and can be removed.
Signed-off-by: Suren Baghdasaryan surenb@google.com
LGTM Acked-by: Michal Hocko mhocko@suse.com
One question below [...]
diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h index 4d9e3a656875..746f6cb07a20 100644 --- a/include/linux/sched/coredump.h +++ b/include/linux/sched/coredump.h @@ -70,7 +70,6 @@ static inline int get_dumpable(struct mm_struct *mm) #define MMF_UNSTABLE 22 /* mm is unstable for copy_from_user */ #define MMF_HUGE_ZERO_PAGE 23 /* mm has ever used the global huge zero page */ #define MMF_DISABLE_THP 24 /* disable THP for all VMAs */ -#define MMF_OOM_VICTIM 25 /* mm is the oom victim */ #define MMF_OOM_REAP_QUEUED 26 /* mm was queued for oom_reaper */ #define MMF_MULTIPROCESS 27 /* mm is shared between processes */
Have you consider renumbering the follow up flags so that we do not have holes in there. Nothing really important but it can confuse somebody in the future.
Missed this note until now. I will renumber the constants to avoid confusion. Thanks, Suren.
-- Michal Hocko SUSE Labs