Re: [PATCH v4 11/15] iommufd: Change the selftest to use iommupt instead of xarray

On 8/26/25 10:18 AM, Jason Gunthorpe wrote:

diff --git a/include/linux/generic_pt/iommu.h b/include/linux/generic_pt/iommu.h index cbe6433550f380..58c9fa74fb0701 100644 --- a/include/linux/generic_pt/iommu.h +++ b/include/linux/generic_pt/iommu.h @@ -73,6 +73,18 @@ struct pt_iommu_info { }; struct pt_iommu_ops {

• /**

• * set_dirty() - Make the iova write dirty
  

Should be: * @set_dirty: Make the iova write dirty

• * @iommu_table: Table to manipulate
  

• * @iova: IO virtual address to start
  

These will be ignored by kernel-doc (for now), but that's OK.

• *
  

• * This is only used by iommufd testing. It makes the iova dirty so that
  

• * read_and_clear_dirty() will see it as dirty. Unlike all the other ops
  

• * this one is safe to call without holding any locking. It may return
  

• * -EAGAIN if there is a race.
  

• */
  

• int (*set_dirty)(struct pt_iommu *iommu_table, dma_addr_t iova);
• /**
  • get_info() - Return the pt_iommu_info structure

* @get_info: Return the pt_iommu_info structure

Should be:> * @iommu_table: Table to query