On Wed, Mar 30, 2022 at 5:43 AM Daniel Latypov dlatypov@google.com wrote:
Before: $ ./tools/testing/kunit/kunit.py parse /dev/null ... [ERROR] Test : invalid KTAP input!
After: $ ./tools/testing/kunit/kunit.py parse /dev/null ... [ERROR] Test <missing>: could not find any KTAP output!
This error message gets printed out when extract_tap_output() yielded no lines. So while it could be because of malformed KTAP output from KUnit, it could also be due to to not having any KTAP output at all.
Try and make the error message here more clear.
Signed-off-by: Daniel Latypov dlatypov@google.com
At first I thought that this was "working as intended", but I agree that it's a bit confusing, so changing it is for the best. (And there's no sense getting too bogged down in the philosophical difference between "invalid TAP" and "not valid TAP" :-))
This works fine here, and the code looks sensible. I tested it with the --json option as well, and the result ("test_cases" being empty) makes sense to me: --- { "name": "KUnit Test Group", "arch": "UM", "defconfig": "kunit_defconfig", "build_environment": "", "sub_groups": [], "test_cases": [], "lab_name": null, "kernel": null, "job": null, "git_branch": "kselftest" } ---
So, this is: Reviewed-by: David Gow davidgow@google.com
Cheers, -- David