7 Mar
2023
7 Mar
'23
1:54 a.m.
Excluding Peter’s comments, LGTM.
On Mar 6, 2023, at 2:50 PM, Axel Rasmussen axelrasmussen@google.com wrote:
@@ -131,8 +131,8 @@ static int mfill_atomic_pte_copy(pmd_t *dst_pmd, struct vm_area_struct *dst_vma, unsigned long dst_addr, unsigned long src_addr,
struct page **pagep,bool wp_copy)
uffd_flags_t flags,struct page **pagep)
Yet, it would be nice if we can be consistent on whether pagep precedes flags or not (it’s the other way around in shmem_mfill_atomic_pte()).