Re: [PATCH -next 3/4] kselftest/arm64: add pmull feature to hwcap test

15 Aug 2023


      在 2023/8/15 0:38, Mark Brown 写道:
...
On Mon, Aug 14, 2023 at 10:17:46AM +0800, Zeng Heng wrote:
...
asm volatile("mrs x0, S3_3_C2_C4_0" : : : "x0");
@@ -359,6 +365,13 @@ static const struct hwcap_data {
   	.cpuinfo = "rng",
   	.sigill_fn = rng_sigill,
   },

{
.name = "PMULL",


.at_hwcap = AT_HWCAP,


.hwcap_bit = HWCAP_PMULL,


.cpuinfo = "pmull",


.sigill_fn = pmull_sigill,


},

Please keep the table alphabatically sorted - the function is in the
right place but this seems to have got reordered.
Oops, sorry for that. I would update v2 and resend with your reviewed 
tag soon.
Thanks for your review.
Zeng Heng

    