On Tue, Jul 1, 2025 at 6:44 AM Alice Ryhl aliceryhl@google.com wrote:
On Thu, Jun 19, 2025 at 11:06:24AM -0400, Tamir Duberstein wrote:
This picks up from Michal Rostecki's work[0]. Per Michal's guidance I have omitted Co-authored tags, as the end result is quite different.
Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky@pro... [0] Closes: https://github.com/Rust-for-Linux/linux/issues/1075
Signed-off-by: Tamir Duberstein tamird@gmail.com
Overall LGTM. Only question is whether we should re-export core::ffi::CStr from kernel::ffi. Reason being that right now we are telling people to never use core::ffi as the integer types are wrong, and I think it would be nice if we can continue to tell people "never use core::ffi".
I agree that'd be nice. There are existing references to items in `core::ffi` scattered around (e.g. in rust/kernel/drm/file.rs); it would be good to clean all those up together with CStr provided we have some ability to lint against new occurrences.
I'll leave this as-is for now since this series has already churned quite a lot, and the cleanup can be a reasonable first task for someone.
Either way, for the whole series: Reviewed-by: Alice Ryhl aliceryhl@google.com
Thanks! I'll send the rebase on rc3 momentarily. Tamir