3 Dec
2020
3 Dec
'20
3:05 a.m.
On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov dlatypov@google.com wrote:
Use self.assertEqual/assertNotEqual() instead. Besides being more appropriate in a unit test, it'll also give a better error message by show the unexpected values.
Also
- Delete redundant check of exception types. self.assertRaises does this.
- s/kall/call. There's no reason to name it this way.
since `mock.call` is in scope as `call`.
- This is probably a misunderstanding from the docs which uses it
Signed-off-by: Daniel Latypov dlatypov@google.com
Looks good, thanks!
Reviewed-by: David Gow davidgow@google.com
-- David