-----Original Message----- From: Ido Schimmel idosch@idosch.org Sent: Tuesday, 22 August 2023 20:57 To: Sriram Yagnaraman sriram.yagnaraman@est.tech Cc: netdev@vger.kernel.org; linux-kselftest@vger.kernel.org; David S . Miller davem@davemloft.net; Eric Dumazet edumazet@google.com; Jakub Kicinski kuba@kernel.org; Paolo Abeni pabeni@redhat.com; David Ahern dsahern@kernel.org; Ido Schimmel idosch@nvidia.com; Shuah Khan shuah@kernel.org Subject: Re: [PATCH 3/3] selftests: forwarding: Add test for load-balancing between multiple servers
On Mon, Aug 21, 2023 at 07:36:47PM +0000, Sriram Yagnaraman wrote:
Do you think it would be OK to drop this patch from the series for now? I can
come back with the selftest when I have something working correctly?
There's a more direct way of testing it and that's by counting the number of times the relevant FIB trace point was triggered. This script [1] does it for IPv4. For IPv6 the equivalent trace point is called fib6:fib6_table_lookup. The script can obviously be made nicer.
Before the patches:
# ./mp_repo.sh 10020
After the patches:
# ./mp_repo.sh 65535
You can see that after the patches the trace point is triggered for every packet. Sometimes it's a bit less. I assume because some events are lost.
Another approach would be to tweak the current test so that $h1 and $rp1 are configured in a similar fashion to veth0 and veth1.
Nice. Thanks a lot, I will send v2 with this approach.