Re: [PATCH 4/4] selftests: can: Document test_raw_filter test cases

On Thu. 24 Apr. 2025 at 16:44, Vincent Mailhol mailhol.vincent@wanadoo.fr wrote:

On Tue. 22 Apr. 2025 at 21:03, Felix Maurer fmaurer@redhat.com wrote:

(...)

...

•   .exp_rxbits = (1 | 1 << (T_EFF) | 1 << (T_RTR) | 1 << (T_EFF | T_RTR)),
  

                    ^                                                      ^

Nitpick: those outermost parentheses are not needed.

This took me time to process. Isn't your expression redundant? What about

.exp_rxbits = 1 | 1 << (T_EFF | T_RTR),

?

This gives me the same result:

https://godbolt.org/z/cr3q5vjMr

Never mind. This was a silly comment. I messed up the operator precedence in the above example, these are obviously different.

Please disregard my comment and sorry for the noise.

Yours sincerely, Vincent Mailhol