Re: [PATCH bpf-next 3/4] selftests/bpf: Add mptcp subflow example

On Tue, May 7, 2024 at 3:53 AM Matthieu Baerts (NGI0) matttbe@kernel.org wrote:

From: Nicolas Rybowski nicolas.rybowski@tessares.net

Move Nicolas's patch into bpf selftests directory. This example added a test that was adding a different mark (SO_MARK) on each subflow, and changing the TCP CC only on the first subflow.

This example shows how it is possible to:

Identify the parent msk of an MPTCP subflow.
Put different sockopt for each subflow of a same MPTCP connection.

Here especially, we implemented two different behaviours:

A socket mark (SOL_SOCKET SO_MARK) is put on each subflow of a same
MPTCP connection. The order of creation of the current subflow defines
its mark.

The TCP CC algorithm of the very first subflow of an MPTCP connection is set to "reno".

why? What does it test? That bpf_setsockopt() can actually do it? But the next patch doesn't check that it's reno.

It looks to me that dropping this "set to reno" part won't change the purpose of the rest of selftest.

pw-bot: cr