On 10/05/2024 19:22, John Hubbard wrote:
On 5/10/24 10:56 AM, John Hubbard wrote:
On 5/10/24 4:52 AM, Ryan Roberts wrote:
On 04/05/2024 05:43, John Hubbard wrote:
...
It just occured to me that the bug report I was fixing with my attempt was invoking make like this (see [1]):
# tools/testing/selftests/fchmodat2$ make CC=clang # tools/testing/selftests/openat2$ make CC=clang
So LLVM is not set in this case. Perhaps my approach [2] (suggested by Arnd) of using cc-option is more robust? (cc-option is alredy used by other selftests).
Yes, I think that would better handle the two cases: setting LLVM, and/or setting CC (!).
For that, some nits, but only worth fussing over if the patch hasn't gone in yet, or if you're changing it for some other reason:
I just remembered it needs the LOCAL_HDRS approach as well. Did your patch already go in? Should I fix up this one here to use cc-option, or go with yours? Either way is fine with me.
I don't think my patch has been taken into any branch - I didn't see a notification anyway. So it would be great if you are happy to take ownership of it? - I'm on Paternity leave for the next 3 weeks so wouldn't get it done until I get back.
thanks,