Re: [PATCH net-next v12 12/22] ovpn: implement multi-peer support

On 02/12/2024 16:07, Antonio Quartulli wrote: [...]

+/**

• • ovpn_peer_unhash - remove peer reference from all hashtables
• • @peer: the peer to remove
• • @reason: the delete reason to attach to the peer
• */

+static void ovpn_peer_unhash(struct ovpn_peer *peer,

• 	     enum ovpn_del_peer_reason reason)
  

+{

• lockdep_assert_held(&peer->ovpn->lock);
• hlist_del_init_rcu(&peer->hash_entry_id);
• hlist_nulls_del_init_rcu(&peer->hash_entry_addr4);
• hlist_nulls_del_init_rcu(&peer->hash_entry_addr6);
• hlist_nulls_del_init_rcu(&peer->hash_entry_transp_addr);
• ovpn_peer_put(peer);

This put() should be dropped as we now call it in ovpn_peer_remove(). Will be fixed in v13.

Regards,