On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook kees@kernel.org wrote:
On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote:
For the all other case, why should we keep argv/argc and mark them unused as well when they aren't being used?
I'm fine either way, but my personal code style instinct is to keep the "standard" main declaration with argc/argv present. But it's mostly aesthetic.
And if you think use of kselftest.h isn't universal, then perhaps we can avoid the macro, but it does seem nicer and more "normal" feeling for the rest of kernel development.
Agreed. __attribute__((unused)) is a bit of a mouthful and isn't what the kernel developer's eye expects to see.