Re: [PATCH] selftests/mincore: Added comment for minicore test

On 5/10/25 02:29, Suresh wrote:

No change log

Signed-off-by: Suresh suresh.k.chandrappa@gmail.com

tools/testing/selftests/mincore/mincore_selftest.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/mincore/mincore_selftest.c b/tools/testing/selftests/mincore/mincore_selftest.c index 17ed3e9917ca..c4f0d21f7678 100644 --- a/tools/testing/selftests/mincore/mincore_selftest.c +++ b/tools/testing/selftests/mincore/mincore_selftest.c @@ -146,6 +146,11 @@ TEST(check_huge_pages) page_size = sysconf(_SC_PAGESIZE); errno = 0;

• /*

•     * Attempt to map a huge page
  

•     * MAP_HUGETLB flag requests a huge page allocation
  

•     * Size is normal page_size, but kernel uses huge page backing
  

•     */
  

Explain why this comment is needed in the change log.

addr = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB, -1, 0);

thanks, -- Shuah