On Sun, Jul 28, 2024 at 12:10:03PM +0200, Thomas Weißschuh wrote:
Makefile.include can modify CC and CFLAGS for usage with clang. Make use of it.
Signed-off-by: Thomas Weißschuh linux@weissschuh.net
tools/testing/selftests/nolibc/Makefile | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile index 8000bc3c408b..cdff317c35f2 100644 --- a/tools/testing/selftests/nolibc/Makefile +++ b/tools/testing/selftests/nolibc/Makefile @@ -155,6 +155,9 @@ CFLAGS ?= -Os -fno-ident -fno-asynchronous-unwind-tables -std=c89 -W -Wall -Wex $(CFLAGS_$(XARCH)) $(CFLAGS_STACKPROTECTOR) $(CFLAGS_EXTRA) LDFLAGS := +# Modify CFLAGS based on LLVM= +include $(srctree)/tools/scripts/Makefile.include
I'm confused, doesn't it precisely undo the previous patch, which said that we ought not to include Makefile.include as it makes it harder for LLVM ?
If so, I suspect that both commits should be squashed with a better explanation for both operations at once (e.g. maybe "move makefile inclusion later to benefit from LLVM=..." etc).
Thanks, Willy