Re: [PATCH v3 02/11] iommufd: Rename _iommufd_object_alloc to iommufd_object_alloc_elm

On Wed, Oct 09, 2024 at 09:38:02AM -0700, Nicolin Chen wrote:

@@ -217,12 +217,12 @@ iommufd_object_put_and_try_destroy(struct iommufd_ctx *ictx, iommufd_object_remove(ictx, obj, obj->id, 0); } -struct iommufd_object *_iommufd_object_alloc(struct iommufd_ctx *ictx,

• 			     size_t size,
  

• 			     enum iommufd_object_type type);
  

+struct iommufd_object *iommufd_object_alloc_elm(struct iommufd_ctx *ictx,

• 				size_t size,
  

• 				enum iommufd_object_type type);
  

Maybe call it raw instead of elm? elm suggests it is an item in an array or likewise

Naming aside

Reviewed-by: Jason Gunthorpe jgg@nvidia.com

Jason