On Mon, May 30, 2022 at 9:17 AM Randy Dunlap rdunlap@infradead.org wrote:
On 5/29/22 14:20, Liam Beguin wrote:
Hi Randy,
On Thu, May 26, 2022 at 01:04:41PM -0700, Randy Dunlap wrote:
On 5/26/22 09:04, Liam Beguin wrote:
Hi Randy,
On Thu, May 26, 2022 at 08:36:34AM -0700, Randy Dunlap wrote:
Liam:
Any comment on this? Otherwise I'll just send a formal patch like this (below).
Apologies for not answering earlier.
I wanted to look more into Masahiro's comment and try to fix the Makefile, but that can be done after.
IMO your patch improves the current Kconfig, so I'd recommend sending the patch. If it can wait a bit, I can look at the Makefile over the weekend.
Liam,
I'll wait until next week to see if you come up with anything.
The following patch fixes the issue while addressing Masahiro's comment. I also considered `select IIO_RESCALE`, but I'm not sure what's usually preferred.
diff --git a/drivers/iio/test/Kconfig b/drivers/iio/test/Kconfig index 56ca0ad7e77a..4c66c3f18c34 100644 --- a/drivers/iio/test/Kconfig +++ b/drivers/iio/test/Kconfig @@ -6,7 +6,7 @@ # Keep in alphabetical order config IIO_RESCALE_KUNIT_TEST bool "Test IIO rescale conversion functions"
depends on KUNIT=y && !IIO_RESCALE
depends on KUNIT=y && IIO_RESCALE=y default KUNIT_ALL_TESTS help If you want to run tests on the iio-rescale code say Y here.diff --git a/drivers/iio/test/Makefile b/drivers/iio/test/Makefile index f15ae0a6394f..880360f8d02c 100644 --- a/drivers/iio/test/Makefile +++ b/drivers/iio/test/Makefile @@ -4,6 +4,6 @@ #
# Keep in alphabetical order -obj-$(CONFIG_IIO_RESCALE_KUNIT_TEST) += iio-test-rescale.o ../afe/iio-rescale.o +obj-$(CONFIG_IIO_RESCALE_KUNIT_TEST) += iio-test-rescale.o obj-$(CONFIG_IIO_TEST_FORMAT) += iio-test-format.o CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN)
I'll send a patch as soon as you confirm this works for you too.
Looks good. Thanks.
Acked-by: Randy Dunlap rdunlap@infradead.org Tested-by: Randy Dunlap rdunlap@infradead.org
-- ~Randy
Reviewed-by: Masahiro Yamada masahiroy@kernel.org