Re: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

On 10/16/18 4:50 PM, Brendan Higgins wrote:

This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel.

Hi,

Just a general comment:

Documentation/process/submitting-patches.rst says: <<Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.>>

That also means saying things like: ... test: add instead of ... test: added and "enable" instead of "enabled" and "improve" instead of "improved" and "implement" instead of "implemented".

thanks.