On Fri, Feb 14, 2025 at 1:38 PM Miguel Ojeda miguel.ojeda.sandonis@gmail.com wrote:
On Fri, Feb 14, 2025 at 3:41 PM Tamir Duberstein tamird@gmail.com wrote:
This is a really helpful comment. It got me wondering: can we have host-side unit tests for our proc macros? Code is better than comments, of course.
That makes sense (in fact, e.g. Benno wanted them for pinned-init), but I will defer that until we have the new build system to avoid adding more things to our plate.
This makes sense. I wonder if we should think about being able to declare a test that runs both on host and in KUnit.
Yeah, when we originally discussed `#[test]`s (years ago), we wanted to have "attributes" or "tags" like `#[test(host, kernel)]`.
But, again, something for later -- I would rather we finally land `#[test]`s.
Cheers, Miguel
Works for me. Could you link to issues tracking these, if they exist?
Reviewed-by: Tamir Duberstein tamird@gmail.com