Re: [PATCH v1 2/7] mm/ksm: simplify break_ksm() to not rely on VM_FAULT_WRITE

On Fri, Sep 30, 2022 at 04:19:26PM +0200, David Hildenbrand wrote:

I don't think that we particularly care about that performance drop when unmerging. If it ever turns out to be an actual performance issue, we can think about a better alternative for FAULT_FLAG_UNSHARE -- let's just keep it simple for now.

It'll be nice to hear from real ksm users for sure. But to me this makes sense, and the patch itself looks good to me, I think that also means:

Acked-by: Peter Xu peterx@redhat.com