On 03.06.25 16:58, Mark Brown wrote:
On Tue, Jun 03, 2025 at 04:15:42PM +0200, David Hildenbrand wrote:
On 03.06.25 15:21, Mark Brown wrote:
} else {
ksft_test_result_fail("Leak from parent into child\n");Same here and in other cases below (I probably didn't catch all).
We should log that somehow to indicate what exactly is going wrong, likely using ksft_print_msg().
Can you send a patch with the logging that you think would be clear please? I dropped these because they just seemed to be reporting the> overall
point of the test, unlike the cases where we ran into some error
during the setup and didn't actually manage to perform the test we were trying to do. Perhaps the tests should be renamed.
ksft_print_msg("Leak from parent into child");
Can you send a patch showing when/where you want this printing please?
I'm really busy right now, unfortunately.
Like I said I suspect the test name is just unclear here...
I would hope we find some mechanical replacement.
E.g.,
ksft_test_result_pass("No leak from parent into child\n");
becomes
ksft_print_msg("No leak from parent into child\n"); log_test_result(KSFT_PASS);
and
ksft_test_result_xfail("Leak from parent into child\n");
becomes
ksft_print_msg("Leak from parent into child\n"); log_test_result(KSFT_FAIL);