Re: [PATCH 3/5] riscv: misaligned: use get_user() instead of __get_user()

On 14/04/2025 14:34, Clément Léger wrote:

Now that we can safely handle user memory accesses while in the misaligned access handlers, use get_user() instead of __get_user() to have user memory access checks.

Signed-off-by: Clément Léger cleger@rivosinc.com

arch/riscv/kernel/traps_misaligned.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index 4354c87c0376..97c674d7d34f 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -268,7 +268,7 @@ static unsigned long get_f32_rs(unsigned long insn, u8 fp_reg_offset, int __ret; \ \ if (user_mode(regs)) { \

• __ret = __get_user(insn, (type __user *) insn_addr); \
  

• __ret = get_user(insn, (type __user *) insn_addr); \
  

  } else { \ insn = *(type *)insn_addr; \ __ret = 0; \

Reviewed-by: Alexandre Ghiti alexghiti@rivosinc.com

Thanks,

Alex