On Fri, Oct 17, 2025 at 5:07 PM Vipin Sharma vipinsh@google.com wrote:
diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c static int __init vfio_pci_core_init(void) { /* Allocate shared config space permission data used by all devices */
vfio_pci_liveupdate_init(); return vfio_pci_init_perm_bits();
The call to vfio_pci_liveupdate_init() should go before the comment associated with vfio_pci_init_perm_bits().
diff --git a/drivers/vfio/pci/vfio_pci_liveupdate.c b/drivers/vfio/pci/vfio_pci_liveupdate.c +static bool vfio_pci_liveupdate_can_preserve(struct liveupdate_file_handler *handler,
struct file *file)+{
return -EOPNOTSUPP;
can_preserve() returns a bool, so this should be "return false". But I think we can just do the cdev fops check in this commit. It is a small enough change.
+static struct liveupdate_file_handler vfio_pci_luo_handler = {
.ops = &vfio_pci_luo_fops,.compatible = "vfio-v1",
This should probably be something like "vfio-pci-v1"?