On Wed, Aug 31, 2022 at 11:10:20AM -0700, Reinette Chatre wrote:
Hi Jarkko,
On 8/30/2022 7:33 PM, Jarkko Sakkinen wrote:
On Tue, Aug 30, 2022 at 03:57:24PM -0700, Reinette Chatre wrote:
Hi Jarkko,
On 8/29/2022 8:12 PM, Jarkko Sakkinen wrote:
Signed-off-by: Jarkko Sakkinen jarkko@kernel.org
tools/testing/selftests/sgx/alloc-error.bt | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 tools/testing/selftests/sgx/alloc-error.bt
diff --git a/tools/testing/selftests/sgx/alloc-error.bt b/tools/testing/selftests/sgx/alloc-error.bt new file mode 100644 index 000000000000..9268d50dea29 --- /dev/null +++ b/tools/testing/selftests/sgx/alloc-error.bt @@ -0,0 +1,7 @@ +kr:sgx_alloc_epc_page /(uint64)retval >= (uint64)(-4095)/ {
printf("sgx_alloc_epc_page: retval=%d\n", (int64)retval);
+}
+kr:sgx_encl_page_alloc /(uint64)retval >= (uint64)(-4095)/ {
printf("sgx_encl_page_alloc: retval=%d\n", (int64)retval);
+}
Could there be a snippet of comments in this new file to guide users on how to use this script?
Do not mean to be rude but I'm not sure what there is to guide but I'm open for ideas.
How about something like below in comments as part of the script:
"bpftrace script using kretprobe to trace returns of some key functions in support of tracking allocation errors."
I think comments that I put (before seeing) also make it clear enough (not to say that what you had not been a valid alternative).
BR, Jarkko