On Thu, Dec 3, 2020 at 3:09 AM Daniel Latypov dlatypov@google.com wrote:
Also take this time to rename get_absolute_path() to test_data_path().
- the name is currently a lie. It gives relative paths, e.g. if I run
from the same dir as the test file, it gives './test_data/<file>'
See https://docs.python.org/3/reference/import.html#__file__, which doesn't stipulate that implementations provide absolute paths.
- it's only used for generating paths to tools/testing/kunit/test_data/
So we can tersen things by making it less general.
Cache the absolute path to the test data files per suggestion from [1]. Using relative paths, the tests break because of this code in kunit.py if get_kernel_root_path(): os.chdir(get_kernel_root_path())
[1] https://lore.kernel.org/linux-kselftest/CABVgOSnH0gz7z5JhRCGyG1wg0zDDBTLoSUC...
Fixes: 5578d008d9e0 ("kunit: tool: fix running kunit_tool from outside kernel tree") Signed-off-by: Daniel Latypov dlatypov@google.com
Thanks: I much prefer this to v1. Having it work the same way as test_tmpdir is a bonus.
Reviewed-by: David Gow davidgow@google.com
Cheers, -- David