Re: [PATCH net-next v10 01/14] netdev: add netdev_rx_queue_restart()

On 2024-05-30 13:16, Mina Almasry wrote: [...]

+err_start_queue:

• /* Restarting the queue with old_mem should be successful as we haven't

• * changed any of the queue configuration, and there is not much we can
  

• * do to recover from a failure here.
  

• *
  

• * WARN if the we fail to recover the old rx queue, and at least free
  

• * old_mem so we don't also leak that.
  

• */
  

• if (dev->queue_mgmt_ops->ndo_queue_start(dev, old_mem, rxq_idx)) {

• WARN(1,
  

•      "Failed to restart old queue in error path. RX queue %d may be unhealthy.",
  

•      rxq_idx);
  

• dev->queue_mgmt_ops->ndo_queue_mem_free(dev, &old_mem);
  

This should be ->ndo_queue_mem_free(dev, old_mem).